[net2-wg] Fwd: CTP beacon successes window bug

[Omprakash Gnawali]

> - 1 (very easy): change the CTP code to compute the estimate after the
> window has expired (if the seqno gap >= BLQ_PKT_WINDOW) (once for N Failures
> + 1 success).
> this would just mean changing one line in each. diffs:
> diff -r tinyos-2.1.0/tos/lib/net/4bitle/LinkEstimatorP.nc
> tinyos-2.1.0-fix/tos/lib/net/4bitle/LinkEstimatorP.nc
> 392c392
> <     if (NeighborTable[idx].rcvcnt >= BLQ_PKT_WINDOW) {
> ---
>>     if (packetGap >= BLQ_PKT_WINDOW) {
> diff -r tinyos-2.1.0/tos/lib/net/le/LinkEstimatorP.nc
> tinyos-2.1.0-fix/tos/lib/net/le/LinkEstimatorP.nc
> 389c389
> <     if (NeighborTable[idx].rcvcnt >= BLQ_PKT_WINDOW) {
> ---
>>     if (packetGap >= BLQ_PKT_WINDOW) {


Juan,

I think there is a bug in this bug fix. It should be packetGap >
BLQ_PKT_WINDOW or rcvcnt > BLQ_PKT_WINDOW. Agree?

- om_p