[Tinyos Core WG] cc2420 radio stack, and short packets

[David Moss]

Ah, yes, you are correct.


-----Original Message-----
From: David Gay [mailto:dgay42 at gmail.com] 
Sent: Tuesday, July 08, 2008 11:12 AM
To: David Moss
Cc: TinyOS Core WG
Subject: Re: [Tinyos Core WG] cc2420 radio stack, and short packets

On Tue, Jul 8, 2008 at 9:58 AM, David Moss <dmm at rincon.com> wrote:
>
> I propose (lines 215-217):
>
>         if(rxFrameLength <= MAC_PACKET_SIZE) {
>           if(rxFrameLength > 0) {
>             if(rxFrameLength >= sizeof(cc2420_header_t)) {

Shouldn't that be: ... >= CC2420_SIZE, given that's what's ultimately
subtracted from rxFrameLength in receiveDone_task, where CC2420_SIZE
== sizeof(cc2420_header_t) - 1 + sizeof(uint16_t)? If I understand
correctly, the length doesn't include the length byte (hence the - 1)
but does include a 2 byte footer (the sizeof(uint16_t)).

David