[Tinyos-devel] Possible bug in broadcast code of LPL with CC2420

[Jun]

Hi All,

I just noticed some inconsistent code for broadcast in CC2420 radio core
when LPL is enabled (tos/chips/cc2420).
Please correct me if I'm wrong.

I first found that ACK is disabled here for a broadcast packet:
lpl/DefaultLplP.nc
487       if(call AMPacket.destination(currentSendMsg) == AM_BROADCAST_ADDR)
{
488         call PacketAcknowledgements.noAck(currentSendMsg);

Then the underlying layer will overwrite the ACK flag regardless of its
previous state:
csma/CC2420CsmaP.nc
139     header->fcf &= 1 << IEEE154_FCF_ACK_REQ;

All the above codes are from the latest CVS.

Thank you,

Jun

-- 
--
Mailto: yanjunrockets at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://www.millennium.berkeley.edu/pipermail/tinyos-devel/attachments/20080430/a489fc3c/attachment.htm