[Tinyos-devel] Re: CC2420ActiveMessageP does not set group id

[Philip Levis]

On Feb 1, 2008, at 4:06 AM, Omprakash Gnawali wrote:

> I think I found at least one group-id-related problem, not necessarily
> related to CC2420ActiveMessageP.
>
> Here is an excerpt from AM.h:
>
> #ifndef DEFINED_TOS_AM_GROUP
> #define DEFINED_TOS_AM_GROUP 0x22
> #endif
> ...
>   TOS_AM_GROUP = DEFINED_TOS_AM_GROUP,
>
> I think DEFINED_TOS_AM_GROUP is a typo. Should it be DEF_TOS_AM_GROUP?
> There is a similar issue about DEFINED_TOS_AM_ADDRESS but it sort of
> works because no other script is probably trying to use this name.
>
> I also saw a reference to DEFINED_TOS_AM_ADDRESS in lesson 13 of the
> tutorial. I think this is a double typo - group id vs am address and
> probably want to call DEF_TOS_AM_ADDRESS to make it consistent with
> the group id.

Fixed. It should be DEFINED_TOS_AM_GROUP. The problem was in the  
Makefiles, which were using the wrong variable.

Phil