[Tinyos-devel] fwdbusy bug in LqiForwardingEngineP.nc

[Omprakash Gnawali]

I see two problems with fwdbusy variable:

1. In static void forward(message_t* msg), if the send call fails,
fwdbusy is set to TRUE but it can never be set to FALSE again. I think
we should set it to TRUE only if the send call returns a success. The
forward function was introduction in revision 1.2.

2. event void SubSend.sendDone(message_t* msg, error_t success), if we
haven't exhausted all the retries, we return regardless of the outcome
of send. If the send call fails, we won't get a chance to set fwdbusy
to FALSE. The return statement was added in version 1.4.

It will be great if Phil, as an author, could take a look at these issues.

- om_p