[Tinyos-devel] msp430hardware.h patch

[Vlado Handziski]

I have partially modified the msp430hardware.h in the spirit of the patch.

Since the old __msp430_have_usart0_with_i2c switch is used throughout the
code, for the time being I believe it is best to have a simple backward
compatibility define instead of testing for both it and the
__MSP430_HAS_I2C__.

I have included your alignment of the low-power test with the
tinyos-2.xcode and some indentation fixes (note, our policy is not to
use tabs in the
indentation)

As for the new TOSH_uwait() implementation, this can not be included in the
provided form since there would be a collision between the TARGET_DCO_KHZ
define in this file and in the enum in MSP430ClockM.nc. This is not a simple
problem of name changing, if this info is duplicated in two files, people
will start making mistakes, modifying the value only in one.

Also, I am not sure how smart it is in general to make such modifications at
this point in the tinyos-1.x lifecycle. This is definitely not the primary
interest of the Core WG at the moment, but if the community comes with well
tested solutions, we can push them to the tree.

Vlado


On Thu, Mar 13, 2008 at 10:01 AM, Vlado Handziski <handzisk at tkn.tu-berlin.de>
wrote:

> Yes. I'll test it today and check it in if all is fine.
>
> Vlado
>
>
> On Wed, Mar 12, 2008 at 9:05 PM, Philip Levis <pal at cs.stanford.edu> wrote:
>
> >
> > On Mar 12, 2008, at 6:26 AM, steve ayer wrote:
> >
> > > hi folks,
> > >
> > > i recently upgraded my mspgcc toolchain in the process of
> > > supporting the new msp430x261x series (more on this soon), and
> > > found that one of the macros used in msp430hardware.h was dropped,
> > > breaking builds of msp430-based devices.
> > > __msp430_have_usart0_with_i2c was replaced with __MSP430_HAS_I2C__;
> > > the attached patch supports both.
> > >
> > > btw, this patch also cleans up some indentation, and provides an
> > > improved version of TOSH_uwait() that one of my erstwhile
> > > colleagues added several years ago, its source noted; this upgrade
> > > can now be considered well-tested.
> > >
> > > i hope that this helps,
> > >
> > > steve
> >
> > Vlado, I think you're nominally the MSP430 maintainer. Do you want to
> > take a look at this and apply it?
> >
> > Phil
> >
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://www.millennium.berkeley.edu/pipermail/tinyos-devel/attachments/20080313/15b3a13b/attachment.html