[Tinyos-devel] HplMsp430InterruptSigP.nc

[Vlado Handziski]

I have several issues with your commit from Apr. 18th:


   - Such major changes need to go through at least a discussion on
   tinyos-devel
   - The current policy of changing core code is to notify the authors in
   the headers of the files (unless agreed otherwise at a phone call or email
   thread here)
   - Having default event handlers for all interrupt sources is not without
   secondary effects. In some cases interrupt flags are cleared just by having
   a ISR defined
   - What was the motivation for the change?
   - Even if the motivation is good, and we double check that no secondary
   effect (apart from the bloat) is going to bite us, this is definitely not
   something that should be buried in /pins !?

Vlado
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://www.millennium.berkeley.edu/pipermail/tinyos-devel/attachments/20080505/e95315fd/attachment.htm