[Tinyos-devel] HplMsp430InterruptSigP.nc

[Kevin Klues]

I thought I did send an email about it, but no one ever responded.
Can't seem to find it now though, so maybe I wrote it and it never got
sent.... sorry about that.

Motivation was for beginning to support threads in the future.  All
interrupt handlers need a small bit of code appended to the bottom of
them, and centralizing all the interrupts seemed the easiest way you
do it. The changes now don't have this bit of code in their, but once
we settled on adding the support for threads, having things arranged
this way seemed easier.  It isn't a *necessary* change, however, and
everything can be reverted back if people feel this isn't the way to
go.  My original email basically said the same thing, but I guess you
never read it (i.e. I never sent it) somehow...

Kevin

On Mon, May 5, 2008 at 10:52 AM, Vlado Handziski
<handzisk at tkn.tu-berlin.de> wrote:
> I have several issues with your commit from Apr. 18th:
>
>
> Such major changes need to go through at least a discussion on tinyos-devel
> The current policy of changing core code is to notify the authors in the
> headers of the files (unless agreed otherwise at a phone call or email
> thread here)
> Having default event handlers for all interrupt sources is not without
> secondary effects. In some cases interrupt flags are cleared just by having
> a ISR defined
> What was the motivation for the change?
>  Even if the motivation is good, and we double check that no secondary
> effect (apart from the bloat) is going to bite us, this is definitely not
> something that should be buried in /pins !?Vlado
>
>



-- 
~Kevin