[Tinyos-devel] Patches to FTSP and CC2420 for 32kHz sync and LPL functionality

[Philip Levis]

On Jun 18, 2009, at 3:26 PM, Razvan Musaloiu-E. wrote:

> Hi!
>
> On Thu, 18 Jun 2009, Philip Levis wrote:
>
>>
>> On Jun 17, 2009, at 5:41 PM, Razvan Musaloiu-E. wrote:
>>
>>> Actually, I implemented a default behavior for LPL some time ago:
>>> 	http://hinrg.cs.jhu.edu/git/?p=razvanm/tinyos-2.x.git
>>
>>
>> Can you point me at where in the tree it is?
>>
>
> The name of the branch is "default-lpl". Getting it by cloning the  
> whole repository can be done using the following commands:
> 	git clone git://hinrg.cs.jhu.edu/git/razvanm/tinyos-2.x.git
> 	cd tinyos-2.x
> 	git checkout -b default-lpl origin/default-lpl
>
> In an already existing git tree the default-lpl can be imported  
> using these commands:
> 	git fetch git://hinrg.cs.jhu.edu/git/razvanm/tinyos-2.x.git default- 
> lpl:refs/remotes/razvanm/default-lpl
> 	git checkout -b default-lpl razvanm/default-lpl

Razvan,

This implementation looks great, with one exception: it would be nice  
if the LPL setting were stored in a component, rather than being an  
enum/define. That way, it is possible to write such a component so  
that the setting could change at runtime. The standard one might just  
be a function wrapper around the enum, but an ADT would be better.

Phil