[Tinyos-devel] Patches to FTSP and CC2420 for 32kHz sync and LPL functionality

[Philip Levis]

On Jun 26, 2009, at 6:35 PM, Razvan Musaloiu-E. wrote:

> I update the default-lpl-new branch to use a  
> SystemLowPowerListeningC instead of DefaultLplSettingsC. The new  
> interface is like this:
>
> interface SystemLowPowerListening
> {
>  command void setLocalSleepInterval(uint16_t interval);
>  command void setRxSleepInterval(uint16_t interval);
>  command void setDelayAfterReceive(uint16_t interval);
>
>  command uint16_t getRxSleepInterval();
>  command uint16_t getDelayAfterReceive();
> }
>
> The setX calls are used by the user application while the getX are  
> used by LplAMSenderP and DefaulLplP. One drawback of this is the  
> fact that it doesn't prevent the user from calling the setX at the  
> wrong time. :|

This looks good -- I think my one comment would be to change  
RxSleepInterval to DefaultDestinationSleepInterval. That seems clearer  
to me.

I agree on the issues with the set calls. One solution here is that  
you have an error_t return value, with can return FAIL if done at the  
wrong time (e.g., radio is on).

Phil